you just moved memory around

As far as I can tell you've only moved the memory from the session daemon to gnome power manager daemon. There is only one instance of each of those programs running, so where are the savings?

Re: you just moved memory around

I'm not quite sure what you mean, and gnome-power-manager is a session daemon.
The saving comes from two points.
* If you have more than one instance of gnome-power-manager per computer (e.g. more than one logged in user)
* If you are not looking at the graphs. When you close gnome-power-statistics, the widget memory is freed, but the data (very small) stays on the session-server.

As far as I can tell, what you say doesn't apply to the Qt widget classes, since they're not templated.

Plot Widget?

The plot and legend are nice. Did you use a particular widget or are they custom?

Re: Plot Widget?

Custom. I've written the widget to be fairly generic, so in theory you could use it for other stuff. Take a look at gpm-graph-widget.c in CVS and tell me what you think.

Awesome

Very cool.

Colors

Richard, this looks really nice, but the use of colors creates a real accessibility problem for people with various forms of color blindness. Try running the screenshot through Vischeck:

http://www.vischeck.com/vischeck/vischeckImage.php

Using color alone as an indicator should be avoided, particularly for more than about six states. Even people with normal color perception can have a difficult time keeping a mental map of twelve colors.

In this case, I would recommend adjusting the line colors so they have discernable brightness values, and changing the event circles to use a combination of shapes and colors. You could use a different shape for each class of event (power source, LCD, DPMS, suspend/hibernate/resume, lid, notification), and a set of brightness-distinguishable colors for the event itself.

The event classes needn't all use the same two or three colors. For example, "On AC" could be a light blue diamond, and "On battery" could be a dark blue diamond. "LCD dim" could be a dark red square, and "LCD resume" could be a light red square. For people with normal color perception, the combination of shapes and colors makes it even easier to create a mental map, while even black-and-white color-blind people (very rare) will still be able to use the shapes and brightness.

Feel free to ping me on IRC.

//shaunm

Re: Colors

Thanks for your reply, I really need good feedback like this. Cheers also for the link, I see what you mean.

What about:

circle light blue ON_AC
circle dark blue ON_BATTERY
square dark yellow SCREEN_DIM
square light yellow SCREEN_RESUME
star red SUSPEND
star dark red HIBERNATE
star pink RESUME
triangle light green LID_CLOSED
triangle dark green LID_OPENED
! mark NOTIFICATION

Always show legend

Very cool graphs. One thing though: I'd always show the legend and remove the checkbox.